NH-76996 Otelcol: collecting Lambda function logs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrytfleung
changed the title
Comment on lines
+110
to
+111
| // Function, | ||
| // Extension, |
There was a problem hiding this comment.
Nit: Do we still need these for later?
There was a problem hiding this comment.
I keep it there so it doesn't have much difference when compared to upstream. (Easier to sync)
jerrytfleung
added a commit
that referenced
this pull request
Jul 18, 2024
* Added logs receiver * Added basic test cases * Decoupled API version from schema version * Fixed the data type of Record for parsing different type of logs * Updated to use semconv v1.25.0 * Added SubscribeEvents function so as to accept events parameter to subscribe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubscribeEventsfunction so as to accept events parameter to subscribeNH-76996